Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICAR to the list of distributions in the docs #6867

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

daniel-saunders-phil
Copy link
Contributor

@daniel-saunders-phil daniel-saunders-phil commented Aug 19, 2023

I added a new distribution in #6831 but it's not appearing on the API reference on the website. I'm pretty sure I just need to change the .rst file in the docs folder.


📚 Documentation preview 📚: https://pymc--6867.org.readthedocs.build/en/6867/

@daniel-saunders-phil
Copy link
Contributor Author

Doesn't seem to be working but I'm at a loss for what else needs to be fixed. I checked recent merged PRs on other distributions and only saw them modifying the .rst files. Could it be related to releases? The ICAR distribution just got added and it hasn't been put into a release yet. So maybe the docs preview is taking the last release + only this PR rather than all recent PRs.

@daniel-saunders-phil daniel-saunders-phil marked this pull request as ready for review August 23, 2023 23:31
@daniel-saunders-phil
Copy link
Contributor Author

Hi @OriolAbril is this something you would know about? I spoke with Chris earlier today and we thought maybe it was a rebasing problem because the ICAR distribution and this .rst file weren't on the same branch. Now they are sync'ed up. Yet the docs preview still isn't showing ICAR as an option. If you have any ideas, I would love to hear them.

@OriolAbril
Copy link
Member

I see it in the preview: https://pymcio--6867.org.readthedocs.build/projects/docs/en/6867/api/distributions/generated/pymc.ICAR.html. Maybe it was a cache issue? (I have no idea how browsers work)

@ricardoV94 ricardoV94 added docs no releasenotes Skipped in automatic release notes generation labels Aug 24, 2023
@ricardoV94 ricardoV94 merged commit 6691943 into pymc-devs:main Aug 24, 2023
9 checks passed
@daniel-saunders-phil daniel-saunders-phil deleted the icar_docs_api branch August 24, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants